fix(frontend): enforce function-wide params position

The concurrent mapper tracked the first params declaration in the Mapper (so
duplicates across heading segments were caught) but checked 'first payload'
with a per-segment vector index. A params(...) in a later ### @exec segment
was therefore accepted even after an earlier segment had executed statements,
and a duplicate could even be reported as a position error.

- track whether any statement has been lowered for the function and require
  params(...) to come before it, across all heading segments
- check duplicates first, then execution order, then the in-segment index
- add negative fixtures 48 (after an earlier segment) and 49 (duplicate
  across segments); update the corpus count and spec wording

Verified: cargo test --workspace --locked green (62 targets).
This commit is contained in:
cflmy committed 2026-11-21 15:36:30 +08:00
1 parent bbeb1de768
commit b38b769932
7 files changed
+57 -15

No files matched your search

+7 -5
View File
@@ -277,9 +277,11 @@ Rules:
segment are visible in later segments. They do not create new functions.
* `params(name: Type, ...)` is legal only as the **first direct execution
payload of an Exec H2 function**, at most once, and not inside a list or
block quote. It is compile-time metadata and may be preceded by prose or a
Knowledge subsection but not by an executing statement. Violations are
`sem.signature_position`; a duplicate declaration is also rejected.
block quote. The position is function-wide: it may be preceded by prose or a
Knowledge subsection, but not by an executing statement in **any** heading
segment of that function (a later `### @exec` section may not add a
signature after earlier code ran). Violations are `sem.signature_position`;
a duplicate declaration anywhere in the function is also rejected.
* A function without `params` keeps the existing free-variable inference.
As before, an inferred signature accepts **named arguments only**; declare
`params(...)` to accept positional arguments. Public functions should declare
@@ -327,7 +329,7 @@ Stable machine-readable codes (the human `message`/`hint` text may change):
| `sem.duplicate_else` | a second `else` for the same `if` |
| `sem.unmatched_end` | `end` with no open control frame |
| `sem.unclosed_control` | an open `if`/`while` at a heading/function/file boundary |
| `sem.signature_position` | `params` not at the first direct payload, duplicated, or in a container |
| `sem.signature_position` | `params` not the first function-wide direct payload, duplicated, or in a container |
| `sem.unsupported_version_directive` | legacy `marqdo_semantics`/syntax-selection front matter |
| `sem.no_entry_function` | `run` with no Exec H2 `main` |
| `sem.inferred_signature` | lint: public function without explicit `params` |
@@ -361,7 +363,7 @@ the existing `Assign`/`Eval`/`Branch`/`Loop`/`Return` IR.
| Branch | ordered list with a first code-span condition | `if cond ... else ... end`; containers are presentation only |
| Loop | bullet list with a first code-span condition | `while cond ... end` |
| Call | block quote containing a call, or a Strong expression | any carrier whose expression is a call |
| Signature | first standalone code span `(n: Int)` after the H2 | `params(n: Int)` as the first direct payload |
| Signature | first standalone code span `(n: Int)` after the H2 | `params(n: Int)` as the first function-wide direct payload |
| Ordinary list | error inside a function | ordinary document structure, zero statements |
| Ordinary quote | error inside a function | ordinary document structure, zero statements |
| Knowledge | implied by position/inertness only | explicit `@knowledge` scope |