From bcfc763ba456758f6abe67396829beb6d032abc6 Mon Sep 17 00:00:00 2001 From: cflmy Date: Thu, 22 Oct 2026 19:04:25 +0800 Subject: [PATCH] =?UTF-8?q?fix(parse):=20=E5=AD=A4=E7=AB=8B=20`*`=20?= =?UTF-8?q?=E8=A1=8C=E4=B8=8D=E5=86=8D=20panic=EF=BC=88exit=20101=20?= =?UTF-8?q?=E2=86=92=20=E5=B9=B2=E5=87=80=E8=AF=8A=E6=96=AD=EF=BC=89?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit qdagent 全仓 labels 扫描期间实测:任何 .mq.md 里有一行只含单个 `*` (markdown 强调残留)时,`*…* = 返回` 分支同时满足 starts_with/ends_with('*'), 切片 &trimmed[1..0] 越界,整条 labels 扫描被一个文件打死(exit 101)。 修复:斜体返回分支要求 len >= 2,裸 `*` 落回 "unrecognized statement" 干净错误而非崩溃。 实测: - tests/errors/lone-asterisk.mq.md → check 报 "unrecognized statement: *", exit 1(不再 101) - gold 回归 error_lone_asterisk_line 通过 - cargo test --release 全套件 0 failed --- src/parse/mod.rs | 8 ++++++-- tests/errors/lone-asterisk.mq.md | 9 +++++++++ tests/gold.rs | 12 ++++++++++++ 3 files changed, 27 insertions(+), 2 deletions(-) create mode 100644 tests/errors/lone-asterisk.mq.md diff --git a/src/parse/mod.rs b/src/parse/mod.rs index 9545364..38af91b 100644 --- a/src/parse/mod.rs +++ b/src/parse/mod.rs @@ -444,8 +444,12 @@ impl<'a> Cursor<'a> { ); } - // v0.3: *…* = return - if trimmed.starts_with('*') && trimmed.ends_with('*') && !trimmed.starts_with("**") { + // v0.3: *…* = return. A lone `*` (markdown emphasis leftover) must NOT + // enter this branch: it both starts and ends with `*`, and the slice + // below would panic (`[1..0]`). Require a real opener+closer pair; a + // bare `*` falls through to the ordinary statement error / narration + // handling instead of crashing the whole process. + if trimmed.starts_with('*') && trimmed.ends_with('*') && trimmed.len() >= 2 && !trimmed.starts_with("**") { let inner = &trimmed[1..trimmed.len() - 1]; return stmt_from_italic_return(inner, span); } diff --git a/tests/errors/lone-asterisk.mq.md b/tests/errors/lone-asterisk.mq.md new file mode 100644 index 0000000..88f4b78 --- /dev/null +++ b/tests/errors/lone-asterisk.mq.md @@ -0,0 +1,9 @@ +--- +title: lone asterisk line must not panic +--- + +# main + +前面是一行只有单个星号的叙述残留。 + +* diff --git a/tests/gold.rs b/tests/gold.rs index c6f6302..dcb2d66 100644 --- a/tests/gold.rs +++ b/tests/gold.rs @@ -763,6 +763,18 @@ fn error_syntax_bad_line() { ); } +/// 回归(qdagent labels 全仓扫描期间实测):孤立的 `*` 行曾令解析器 panic +/// (`begin <= end (1 <= 0)`,exit 101,整条 labels 扫描被一个文件打死)。 +/// 修复后必须是干净的 `unrecognized statement` 诊断,而不是进程崩溃。 +#[test] +fn error_lone_asterisk_line() { + assert_err( + "tests/errors/lone-asterisk.mq.md", + "9:1", + "unrecognized statement", + ); +} + #[test] fn error_div_zero() {