fix(parse): diagnose unclosed code-shaped bold

Treat `` **x = 1 `` as Code and error with a clear unclosed-`**` diagnostic instead of silently skipping it as a comment.

Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
cflmyandCursor committed 2026-09-14 14:39:58 +08:00
1 parent 95a49697f7
commit 6f303ff957
6 files changed
+86 -30

No files matched your search

+2 -1
View File
@@ -53,7 +53,8 @@
- [x] else 臂 `N. *` 与返回斜体消歧
- [x] 一行多 `**…**` 按序执行
- [x] 金样例:`---` / `*None*` / 整行 `**` / 兼容 `****`;叙述死绑定不升参
- [ ] 诊断:必选缺失、未知 callee;空返回残缺粗体;死变量仅可选 lint
- [x] 诊断:必选缺失、未知 callee(已有 errors 金样);未闭合代码形粗体;死变量不报错
- [ ] (可选)死变量 hint lint;空返回其它歧义边角
**出门:** `tests/markup-v03/*` 覆盖设计 §9 示例。
+52
View File
@@ -43,6 +43,47 @@ fn is_code_starter(c: char) -> bool {
) || c.is_ascii_digit()
}
/// Whether `**inner**` should execute (assign / call / expr), not soft emphasis.
pub fn looks_like_bold_code(inner: &str) -> bool {
let t = inner.trim();
if t.is_empty() {
return false;
}
if t.contains('=') || t.starts_with('>') {
return true;
}
if t.chars()
.any(|c| matches!(c, '+' | '-' | '*' | '/' | '(' | ')' | '[' | ']'))
{
return true;
}
let parts: Vec<&str> = t.split_whitespace().collect();
if parts.len() >= 2 {
return parts[1..].iter().any(|p| {
p.contains('=')
|| p.starts_with('"')
|| p.starts_with('\'')
|| p.starts_with('`')
|| p.chars().all(|c| c.is_ascii_digit())
|| (p.contains('.')
&& p.chars()
.filter(|c| *c != '.')
.all(|c| c.is_ascii_digit()))
});
}
false
}
/// `` **code-shaped… `` without a closing `**` (should diagnose, not skip as comment).
fn looks_like_unclosed_bold_code(trimmed: &str) -> bool {
let t = trimmed.trim();
if !t.starts_with("**") || matching_bold_close(t).is_some() {
return false;
}
// Whole-line empty markers are handled by is_marqdo_star_line.
looks_like_bold_code(&t[2..])
}
/// Whole-line backtick bind `` `name` = … `` (empty RHS / fence / table OK).
///
/// Narrative decls are **not** binds:
@@ -253,6 +294,7 @@ pub fn classify_line(text: &str) -> LineKind {
let first = trimmed.chars().find(|c| !c.is_whitespace());
match first {
None => LineKind::Blank,
Some('*') if looks_like_unclosed_bold_code(trimmed) => LineKind::Code,
Some('*') if !is_marqdo_star_line(trimmed) => LineKind::Comment,
Some('`') if looks_like_backtick_assign(trimmed) => LineKind::Code,
Some('`') => LineKind::Comment,
@@ -433,6 +475,16 @@ mod tests {
LineKind::Code,
"spaced = is backtick assign"
);
assert_eq!(
classify_line("**x = 1"),
LineKind::Code,
"unclosed code-shaped bold → Code for diagnosis"
);
assert_eq!(
classify_line("**说明"),
LineKind::Comment,
"unclosed soft emphasis stays comment"
);
}
#[test]
+13
View File
@@ -363,6 +363,19 @@ impl<'a> Cursor<'a> {
});
}
// Unclosed code-shaped bold (classified Code so we can diagnose).
if trimmed.starts_with("**")
&& !(trimmed.ends_with("**") && trimmed.len() >= 4)
&& crate::lex::looks_like_bold_code(&trimmed[2..])
{
return Err(Diagnostic::new(
None,
span,
"unclosed bold code: expected closing `**`".to_string(),
)
.into());
}
// v0.3: **…** = code segment (assign / call / expr)
if trimmed.starts_with("**") && trimmed.ends_with("**") && trimmed.len() >= 4 {
let inner = &trimmed[2..trimmed.len() - 2];
+2 -29
View File
@@ -5,6 +5,8 @@
use crate::lex::{matching_bold_close_inline, matching_italic_close_inline};
pub use crate::lex::looks_like_bold_code;
#[derive(Debug, Clone, PartialEq, Eq)]
pub enum ProseBit {
/// `` `ident` `` or `` `ident`=default `` (default string is raw RHS text).
@@ -71,35 +73,6 @@ pub fn scan_prose_line(line: &str) -> Vec<ProseBit> {
out
}
/// Whether `**inner**` should execute (assign / call / expr), not soft emphasis.
pub fn looks_like_bold_code(inner: &str) -> bool {
let t = inner.trim();
if t.is_empty() {
return false;
}
if t.contains('=') || t.starts_with('>') {
return true;
}
if t.chars().any(|c| matches!(c, '+' | '-' | '*' | '/' | '(' | ')' | '[' | ']')) {
return true;
}
let parts: Vec<&str> = t.split_whitespace().collect();
if parts.len() >= 2 {
return parts[1..].iter().any(|p| {
p.contains('=')
|| p.starts_with('"')
|| p.starts_with('\'')
|| p.starts_with('`')
|| p.chars().all(|c| c.is_ascii_digit())
|| (p.contains('.')
&& p.chars()
.filter(|c| *c != '.')
.all(|c| c.is_ascii_digit()))
});
}
false
}
/// Whether `*inner*` is a return (vs mid-prose English/CJK emphasis).
fn looks_like_italic_return(line: &str, at: usize, after: usize, inner: &str) -> bool {
let t = inner.trim();
+8
View File
@@ -0,0 +1,8 @@
---
title: unclosed bold code
description: code-shaped `**…` without closing `**` must diagnose
---
# main
**x = 1
+9
View File
@@ -610,6 +610,15 @@ fn error_syntax_bad_line() {
);
}
#[test]
fn error_unclosed_bold() {
assert_err(
"tests/errors/unclosed-bold.mq.md",
"8:1",
"unclosed bold code",
);
}
#[test]
fn error_div_zero() {
assert_err("tests/errors/div-zero.mq.md", "7:1", "division by zero");